From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Vinod Koul <vinod.koul@intel.com>, Felipe Balbi <balbi@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [4.0-rc+] WARNING: CPU: 0 PID: 1 at ./drivers/dma/dmaengine.c:863 dma_async_device_register+0xe0/0x540()
Date: Thu, 9 Apr 2015 13:49:19 +0200 [thread overview]
Message-ID: <20150409114919.GM26727@lukather> (raw)
In-Reply-To: <552654F1.6020300@hurleysoftware.com>
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
On Thu, Apr 09, 2015 at 06:31:13AM -0400, Peter Hurley wrote:
> On 04/09/2015 03:09 AM, Maxime Ripard wrote:
> > On Wed, Apr 08, 2015 at 12:07:14PM -0400, Peter Hurley wrote:
> >> On 04/08/2015 11:59 AM, Maxime Ripard wrote:
> >>> On Wed, Apr 08, 2015 at 11:53:33AM -0400, Peter Hurley wrote:
> >>>> On 03/05/2015 11:12 AM, Vinod Koul wrote:
> >>>>> On Thu, Mar 05, 2015 at 10:04:21AM -0500, Peter Hurley wrote:
> >>>>>>> First boot of 4.0-rc+ gave me [1] on a Beaglebone Black due to
> >>>>>>>
> >>>>> The warning is intentional to get driver fixed and give the right behaviour
> >>>>>
> >>>>> Felipe had sent a patch for this but that one needs an update
> >>>>
> >>>> Vinod,
> >>>>
> >>>> Felipe's patch never made it to mainline, and this warning is
> >>>> still happening on 4.0-rc7 so please revert for 4.0-final.
> >>>
> >>> That patch isn't introducing any regression. I fail to see how that
> >>> justifies a revert so late in the release cycle.
> >>
> >> Arguably it never should have been introduced in the first place
> >
> > Upon which arguments? So far, I've seen none but "my boot logs look
> > bad now".
>
> 1. Every subsystem has drivers that don't fully conform to a desired
> interface. If even a small fraction did this, everyone's logs would
> be cluttered with this garbage. For that matter, if just the serial
> subsystem alone did this, logs would be awash in warnings.
And a lot of subsystems do this for drivers where the way to fix this
is not clear and/or easy to obtain.
Which is exactly the case here.
> 2. Now _every_ dmaengine driver "fix" for this will need to be pushed
> to -stable.
It won't. Such changes are not elligible, especially since they are
not critical fixes.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-09 11:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 15:04 [4.0-rc+] WARNING: CPU: 0 PID: 1 at ./drivers/dma/dmaengine.c:863 dma_async_device_register+0xe0/0x540() Peter Hurley
2015-03-05 16:12 ` Vinod Koul
2015-04-08 15:53 ` Peter Hurley
2015-04-08 15:59 ` Maxime Ripard
2015-04-08 16:07 ` Peter Hurley
2015-04-08 16:09 ` Felipe Balbi
2015-04-08 16:23 ` Peter Hurley
2015-04-09 7:09 ` Maxime Ripard
2015-04-09 10:31 ` Peter Hurley
2015-04-09 11:49 ` Maxime Ripard [this message]
2015-04-08 16:26 ` Peter Hurley
2015-04-09 7:07 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409114919.GM26727@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=balbi@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).