From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932835AbbDIMTs (ORCPT ); Thu, 9 Apr 2015 08:19:48 -0400 Received: from mail.kernel.org ([198.145.29.136]:58236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754879AbbDIMTq (ORCPT ); Thu, 9 Apr 2015 08:19:46 -0400 Date: Thu, 9 Apr 2015 14:19:14 +0200 From: Sebastian Reichel To: Pavel Machek Cc: Sakari Ailus , Andrew Morton , pali.rohar@gmail.com, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, galak@codeaurora.org, bcousson@baylibre.com, m.chehab@samsung.com, devicetree@vger.kernel.org, mchehab@osg.samsung.com, hverkuil@xs4all.nl Subject: Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 Message-ID: <20150409121913.GB18713@earth> References: <20150403113216.GK20756@valkosipuli.retiisi.org.uk> <20150403202624.GA4308@amd> <20150403213655.GO20756@valkosipuli.retiisi.org.uk> <20150404074337.GA31064@amd> <20150404102435.GR20756@valkosipuli.retiisi.org.uk> <20150404171116.GA15025@Nokia-N900> <20150404200307.GS20756@valkosipuli.retiisi.org.uk> <20150409074238.GA22603@amd> <20150409091017.GA4526@earth> <20150409112943.GA31173@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <20150409112943.GA31173@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: > On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > > > [...] > > > +#include > > > +#include > > > [...] > >=20 > > This should probably be > >=20 > > #include > > #include >=20 > And I thought people would only bikesched paint on the > Documentation. Sakari, feel free to change that, but > a) I don't see why Sebastian's version is better You neither use nor . Well "include/linux/gpio.h" describes the old gpio API. The new gpiod gpiod API is described in "include/linux/gpio/consumer.h" and you use it, so the include should be included ;) You don't use anything from "include/linux/of_gpio.h", but it includes "include/linux/of.h", which you are using. So you should include instead ;) > b) am pretty sure there is about infinite number of > possibilities there. Yes, but most are wrong. You should include all headers, that are used by you - nothing more and nothing less. -- Sebastian --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVJm4/AAoJENju1/PIO/qakUwP/j+pIZlLYhC5zZ8T3fSP0iwy 9Kapsg9VLs8iyvc89urlzI/tfWf6i2WhDNboC9gYuQ6ivU87YeH482Er0bSPlsiM uVXGN3PV0O1fdvbekoKWU0tjYQMywoNqJzNMeTDhXj3P08/SUspC2H23W2PK5AH6 mB7GKHZloEkqQkIC7KvStuohrwiyH81YatQVNAUPxlcrb7FsNNAbiEd2x1PbvVfj 8q0cGBjND448DkFH32QZmE5kVE8A0fmqAPSmruJqXUx1R7aucCkAHWKvXS9MGwz7 4aHibMaPEaLaMqD0aS/npgUGS8nwuI80yinzi75sXDylcFYVuURTqigaEj7+N6Hy o3f6/zxZD8spTtPWGuu7i5CnpxmbeaGUQcuSABFR/okbloSl+gob7hzhcGB1qtHs +284ckVrC7AyquMk+phK6qdYjC1zWQO9PmjJo44q6lvEsSRNHwe1OipaYI2gWMbI d/cfXlVB+BkBV3SAIilmtyvGsBcDr0yRdcu6B55cmO0tHqYPPVB5GvGw0S6NnYp2 +c0mvGcpk1nNYGNUwp0tv6pDIpqdvKfE05K2jWslNzmsXjRjzsEFsObdprbfiWG1 aDp9Iiyj3ddnsAkRucTCm9W6mtp/EqVtRo2LK87HFKy68+7nx5yMhYSN7q8GtfM3 UHAXuYDzkSvGua31P8Aa =4AM/ -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--