linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Quentin Lambert <lambert.quentin@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL
Date: Thu, 9 Apr 2015 18:13:16 +0300	[thread overview]
Message-ID: <20150409151316.GO10964@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.10.1504091652420.2598@hadrien>

On Thu, Apr 09, 2015 at 04:53:48PM +0200, Julia Lawall wrote:
> 
> 
> On Thu, 9 Apr 2015, Dan Carpenter wrote:
> 
> > Sorry, my last email was bad.
> >
> > Splitting patches into logical parts is a bit tricky.  Let me try
> > explain better.
> >
> > Every patch should sort of make sense on its own.  In the original code
> > it's using GFP_ATOMIC but that's because the original API was bad and
> > we had no choice.  In the 1/1 patch we're using GFP_ATOMIC explicitly
> > by choice and it's wrong.  In patch 2/2 we fix this problem but we
> > shouldn't introduce bad code even if we fix it in later patches.
> 
> But if Quentin's analysis is wrong, then we have to undo the GFP_KERNEL
> choice, and with only one patch we end up back at the pci API?

We still only have to revert one patch either way.

regards,
dan carpenter


      reply	other threads:[~2015-04-09 15:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 11:46 [PATCH 0/2] pci to dma Quentin Lambert
2015-04-09 11:46 ` [PATCH 1/2] ide: remove deprecated use of pci api Quentin Lambert
2015-04-09 12:35   ` Dan Carpenter
2015-04-13 12:25   ` One Thousand Gnomes
2015-04-13 17:08     ` David Miller
2015-04-13 17:23       ` Dan Carpenter
2015-04-13 17:39         ` David Miller
2015-04-09 11:46 ` [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL Quentin Lambert
2015-04-09 12:36   ` Dan Carpenter
2015-04-09 14:33     ` Quentin Lambert
2015-04-09 14:40       ` Dan Carpenter
2015-04-09 14:50       ` Dan Carpenter
2015-04-09 14:51         ` Quentin Lambert
2015-04-09 14:53         ` Julia Lawall
2015-04-09 15:13           ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409151316.GO10964@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lambert.quentin@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).