From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932205AbbDJMFx (ORCPT ); Fri, 10 Apr 2015 08:05:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46399 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754708AbbDJMFu (ORCPT ); Fri, 10 Apr 2015 08:05:50 -0400 Date: Fri, 10 Apr 2015 14:05:45 +0200 From: Jiri Olsa To: Alexandre Montplaisir Cc: He Kuang , bigeasy@linutronix.de, jolsa@kernel.org, acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf data: Show error message when ctf setup failed Message-ID: <20150410120545.GC31326@krava.brq.redhat.com> References: <1428468560-27401-1-git-send-email-hekuang@huawei.com> <20150408174510.GA20250@krava.redhat.com> <55263608.2070301@huawei.com> <20150409094654.GA1321@krava.brq.redhat.com> <55268EBB.3020807@voxpopuli.im> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55268EBB.3020807@voxpopuli.im> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2015 at 10:37:47AM -0400, Alexandre Montplaisir wrote: > On 2015-04-09 05:46 AM, Jiri Olsa wrote: > >On Thu, Apr 09, 2015 at 04:19:20PM +0800, He Kuang wrote: > >>Hi, jirka > >>On 2015/4/9 1:45, Jiri Olsa wrote: > >>>On Wed, Apr 08, 2015 at 12:49:19PM +0800, He Kuang wrote: > >>>>Show message when errors occurred during ctf conversion setup. > >>>> > >>>>Before this patch: > >>>> $ ./perf data convert --to-ctf=ctf > >>>> $ echo $? > >>>> 255 > >>>> > >>>>After this patch: > >>>> $ ./perf data convert --to-ctf=ctf > >>>> Error during CTF convert setup. > >>>so I have like 5 more patches from the original CTF set > >>>which I'm holding until all works with tracecompass: > >>> http://marc.info/?l=linux-kernel&m=142736197610573&w=2 > >>> > >>>Is it working for you? How do you test resulted CTF data? > >>> > >>>anyway the patch looks ok, just small nit below > >>I tested by using babeltrace binary and it works. > >> > >>After receiving your reply, I test on the latest tracecompass. A > >>folder named 'ctf' is showed instead of the expected file > >>'ctf-data', this folder only contains the raw metadata and > >>perf-stream files but not analysed. > >CC-ing Alexandre from tracecompass devel ^^^ > > Hi, > > I just came back from vacation, sorry for not replying earlier! > > I managed to compile perf with CTF support, but by using Babeltrace's commit > 5584a48. It fails to compile against current master, because of private > headers getting exposed. I reported that to the BT maintainers. there's fix in babeltrace tree already > > Then it seems there's another bug with Trace Compass's current master, trace > validation cannot fail, and any file will get imported with no errors. We > will look into this. > But the root of the problem was that the converted CTF trace was not being > recognized as valid. This is because some events define "stream_id = 0;", > and others don't specify a stream_id at all. It seems quite random, see the > full metadata here: http://pastebin.com/pACgV5JU > > Is there a reason why some events specify a stream_id and some don't? hum, that seems like a bug.. I'll check > > We could patch Trace Compass to accept it, since Babeltrace does. But it's > not very clear according to the spec, I'll check with the CTF guys if it > should be considered valid or not. thanks, jirka