From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Jiri Olsa" <jolsa@kernel.org>,
acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
"Wang Nan" <wangnan0@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure
Date: Fri, 10 Apr 2015 14:38:05 +0200 [thread overview]
Message-ID: <20150410123805.GA22510@krava.brq.redhat.com> (raw)
In-Reply-To: <55277E2D.6030809@huawei.com>
On Fri, Apr 10, 2015 at 03:39:25PM +0800, He Kuang wrote:
> Hi, Jérémie
> On 2015/4/10 3:57, Jérémie Galarneau wrote:
> >Hi He,
> >
> >This commit should fix the problem:
> >
> >commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334
> >Author: Jérémie Galarneau <jeremie.galarneau@efficios.com>
> >Date: Thu Apr 9 14:57:44 2015 -0400
> >
> > Fix: Allow the addition of environment fields to a frozen trace
> >
> > Commit 7f800dc7 introduced a behavior change which made it
> > impossible to add environment fields to a frozen trace (after the
> > creation of a stream).
> >
> > This fix makes it possible to add new fields to a trace's
> > environment while making it impossible to modify existing fields
> > hereby restoring CTF Writer's v1.2 behavior.
> >
> > Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
> >
> >Can you reproduce the problem with the latest Babeltrace master?
> >Otherwise, is there a branch I can checkout to try it out?
> >
> >Jérémie
>
> By updating to the latest libbabeltrace which contains commit
> a0d12916, perf ctf conversion works with or without my patch.
works nicely for me too, thanks!
jirka
next prev parent reply other threads:[~2015-04-10 12:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 4:49 [PATCH 1/2] perf data: Show error message when ctf setup failed He Kuang
2015-04-08 4:49 ` [PATCH 2/2] perf data: Fix ctf_writer setupenv failure He Kuang
2015-04-08 17:59 ` Jiri Olsa
2015-04-09 7:38 ` He Kuang
2015-04-09 19:57 ` Jérémie Galarneau
2015-04-10 7:39 ` He Kuang
2015-04-10 12:38 ` Jiri Olsa [this message]
2015-04-08 17:45 ` [PATCH 1/2] perf data: Show error message when ctf setup failed Jiri Olsa
2015-04-09 7:56 ` [PATCHv2 1/2] perf data: Show error message when conversion failed He Kuang
2015-04-09 9:45 ` Jiri Olsa
2015-04-18 14:00 ` Jiri Olsa
2015-04-09 8:19 ` [PATCH 1/2] perf data: Show error message when ctf setup failed He Kuang
2015-04-09 9:46 ` Jiri Olsa
2015-04-09 14:37 ` Alexandre Montplaisir
2015-04-10 12:05 ` Jiri Olsa
2015-04-10 12:37 ` Jiri Olsa
2015-04-13 20:30 ` Jérémie Galarneau
2015-04-14 17:47 ` Jérémie Galarneau
2015-04-18 13:58 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410123805.GA22510@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=hekuang@huawei.com \
--cc=jeremie.galarneau@efficios.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).