From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756325AbbDOSAH (ORCPT ); Wed, 15 Apr 2015 14:00:07 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34839 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753753AbbDOR7o (ORCPT ); Wed, 15 Apr 2015 13:59:44 -0400 Date: Wed, 15 Apr 2015 10:59:36 -0700 From: Brian Norris To: Sascha Hauer Cc: Eduardo Valentin , Stephen Warren , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mikko Perttunen , linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Zhang Rui , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 13/13] thermal: of: implement .set_trips for device tree thermal zones Message-ID: <20150415175936.GR32500@ld-irv-0074> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-14-git-send-email-s.hauer@pengutronix.de> <20150407024307.GH4648@localhost.localdomain> <20150413063018.GT9742@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150413063018.GT9742@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2015 at 08:30:18AM +0200, Sascha Hauer wrote: > On Mon, Apr 06, 2015 at 07:43:08PM -0700, Eduardo Valentin wrote: > > On Thu, Mar 26, 2015 at 04:54:00PM +0100, Sascha Hauer wrote: > > > Signed-off-by: Sascha Hauer > > > --- > > > drivers/thermal/of-thermal.c | 12 ++++++++++++ > > > include/linux/thermal.h | 1 + > > > 2 files changed, 13 insertions(+) > > > > Can you please include at least one user of this call back in your patch > > series? > > Thanks for the comments on this series. I'll address them in the next > round. The user for this callback is not yet ready to be posted. I'll > try and move this patch to the end of the series so that the series can > be applied without this one. I'm actually interested in this patch, as I am developing a thermal sensor driver that has hardware-assisted temperature-trip interrupts. I'm testing out your patches now, and will probably end up using them on my local tree. With help of this (and a few other changes I need to make), my driver should be ready to post soon. So, I'll try to post my driver soon as an example, if you'd like. I'd also appreciate a CC on any future revisions, if you don't mind. I'm subscribed to the list, but it's not always easy to pick out the signal from the noise. Thanks, Brian P.S. Time for a mild complaint: I think it seems to be a bit of a plague in the thermal subsystem; there are API's, and even user-space ABI's (!!) that have no in-kernel users! e.g., generate_netlink_event() http://article.gmane.org/gmane.linux.power-management.general/58685