From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754108AbbDPICn (ORCPT ); Thu, 16 Apr 2015 04:02:43 -0400 Received: from mail-by2on0140.outbound.protection.outlook.com ([207.46.100.140]:38456 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752192AbbDPICc (ORCPT ); Thu, 16 Apr 2015 04:02:32 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; samsung.com; dkim=none (message not signed) header.d=none; Date: Thu, 16 Apr 2015 15:59:58 +0800 From: Peter Chen To: "Ivan T. Ivanov" CC: Chanwoo Choi , "Balbi, Felipe" , "ABRAHAM, KISHON VIJAY" , Roger Quadros , Robert Baldyga , , , , , Subject: Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection Message-ID: <20150416075957.GB1709@shlinux2> References: <552CE5C0.3010207@ti.com> <552CEC97.1050205@samsung.com> <552CEE42.1050907@ti.com> <552CFA1E.5070400@samsung.com> <20150415032734.GA29095@shlinux2> <552E1862.6090709@ti.com> <552E2EBF.5090906@samsung.com> <20150416015922.GB22269@shlinux2> <552F5E17.5020902@samsung.com> <1429168424.26621.1.camel@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1429168424.26621.1.camel@mm-sol.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(377454003)(377424004)(189002)(479174004)(51704005)(24454002)(199003)(93886004)(85426001)(6806004)(83506001)(105606002)(46102003)(50466002)(77156002)(62966003)(2950100001)(76176999)(54356999)(50986999)(4001350100001)(77096005)(46406003)(47776003)(33716001)(97756001)(33656002)(86362001)(87936001)(92566002)(106466001)(104016003)(110136001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0301MB1206;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1206; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BY1PR0301MB1206;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1206; X-Forefront-PRVS: 0548586081 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2015 08:02:29.0681 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1206 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2015 at 10:13:44AM +0300, Ivan T. Ivanov wrote: > Hi, > > On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: > > Hi Peter, > > > > On 04/16/2015 10:59 AM, Peter Chen wrote: > > > > > > > Ok, from USB point, external id/vbus value can't decide > > > which role the controller will be, the controller driver > > > will decide role according to many things, eg, user configurations, > > > id/vbus value, OTG HNP, etc. > > > > > > So, from USB controller/phy driver, it doesn't care which cable is > > > inserted, it cares about id/vbus value. Eg, it can get id/vbus value > > > and it will be notified when the id/vbus value has changed. > > > > OK, I change the notifier name and add notifier events as following: > > > > - extcon_{register|unregister}_usb_notifier(struct extcon_dev *edev, struct notifier_block *nb); > > - list of notifier events > > #define EXTCON_USB_ID_L_VBUS_L0 /* ID low and VBUS low */ > > #define EXTCON_USB_ID_L_VBUS_H1 /* ID low and VBUS high */ > > #define EXTCON_USB_ID_H_VBUS_L2 /* ID high and VBUS low */ > > #define EXTCON_USB_ID_H_VBUS_H3 /* ID high and VBUS high */ > > I am still confused, why we mix ID and VBUS events into one? > Those are two lines and they are not necessarily handled by > the same extcon_dev. Yes, from consumer side, we only need one element per time, eg vbus or id. -- Best Regards, Peter Chen