From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbbDRIz5 (ORCPT ); Sat, 18 Apr 2015 04:55:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45476 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbbDRIzz (ORCPT ); Sat, 18 Apr 2015 04:55:55 -0400 Date: Sat, 18 Apr 2015 10:55:50 +0200 From: Greg Kroah-Hartman To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Arnd Bergmann , javier@javigon.com, Herbert Xu , tpmdd-devel@lists.sourceforge.net, valentin.manea@huawei.com, jean-michel.delorme@st.com, emmanuel.michel@st.com Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem Message-ID: <20150418085550.GA29858@kroah.com> References: <1429257057-7935-1-git-send-email-jens.wiklander@linaro.org> <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > +/** > + * struct tee_cmd_data - Opaque command argument > + * @buf_ptr: [in] A __user pointer to a command buffer > + * @buf_len: [in] Length of the buffer above > + * > + * Opaque command data which is passed on to the specific driver. The command > + * buffer doesn't have to reside in shared memory. > + * Used as argument for TEE_IOC_CMD below. > + */ > +struct tee_ioctl_cmd_data { > + uint64_t buf_ptr; > + uint64_t buf_len; > +}; All structures that cross the user/kernel boundry must use the __ variant of variable names. So for this one, it must be __u64. Same for all of your ioctl structures. thanks, greg k-h