Re: [RFC PATCH 1/2] tee: generic TEE subsystem - Russell King

From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
	valentin.manea@huawei.com, devicetree@vger.kernel.org,
	javier@javigon.com, emmanuel.michel@st.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, jean-michel.delorme@st.com,
	tpmdd-devel@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Sat, 18 Apr 2015 10:04:20 +0100	[thread overview]
Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150418085712.GB29858@kroah.com>

On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> > +struct tee_device {
> > +	char name[TEE_MAX_DEV_NAME_LEN];
> > +	const struct tee_desc *desc;
> > +	struct device *dev;
> 
> No, please embed the device in your structure, don't have a pointer to
> it.

Greg, "dev" here is not a locally allocated device, but the parent device.
It's actually the same as struct tee_device.miscdev.parent, which could be
used instead and this member deleted.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.