From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754400AbbDTHGc (ORCPT ); Mon, 20 Apr 2015 03:06:32 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:34821 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754255AbbDTHG3 (ORCPT ); Mon, 20 Apr 2015 03:06:29 -0400 Date: Mon, 20 Apr 2015 09:06:24 +0200 From: Ingo Molnar To: Dan Williams Cc: linux-nvdimm@ml01.01.org, Boaz Harrosh , Neil Brown , Greg KH , linux-kernel@vger.kernel.org, Andy Lutomirski , Jens Axboe , "H. Peter Anvin" , Christoph Hellwig , Linus Torvalds , Andrew Morton Subject: Re: [PATCH 02/21] ND NFIT-Defined/NVIDIMM Subsystem Message-ID: <20150420070624.GB13876@gmail.com> References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com> <20150418013525.25237.45181.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150418013525.25237.45181.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dan Williams wrote: > Maintainer information and documenation for drivers/block/nd/ > > Cc: Andy Lutomirski > Cc: Boaz Harrosh > Cc: H. Peter Anvin > Cc: Jens Axboe > Cc: Ingo Molnar > Cc: Christoph Hellwig > Cc: Neil Brown > Cc: Greg KH > Signed-off-by: Dan Williams > --- > Documentation/blockdev/nd.txt | 867 +++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 34 +- > 2 files changed, 895 insertions(+), 6 deletions(-) > create mode 100644 Documentation/blockdev/nd.txt > > diff --git a/Documentation/blockdev/nd.txt b/Documentation/blockdev/nd.txt > new file mode 100644 > index 000000000000..bcfdf21063ab > --- /dev/null > +++ b/Documentation/blockdev/nd.txt > @@ -0,0 +1,867 @@ > + The NFIT-Defined/NVDIMM Sub-system (ND) > + > + nd - kernel abi / device-model & ndctl - userspace helper library > + linux-nvdimm@lists.01.org > + v9: April 17th, 2015 > + > + > + Glossary > + > + Overview > + Supporting Documents > + Git Trees > + > + NFIT Terminology and NVDIMM Types > > [...] > > +The “NVDIMM Firmware Interface Table” (NFIT) [...] Ok, I'll bite. So why on earth is this whole concept and the naming itself ('drivers/block/nd/' stands for 'NFIT Defined', apparently) revolving around a specific 'firmware' mindset and revolving around specific, weirdly named, overly complicated looking firmware interfaces that come with their own new weird glossary?? Firmware might be a discovery method - or not. A non-volatile device might be e820 enumerated, or PCI discovered - potentially with all discovery handled by the driver. Why do you restrict this driver to a naming and design that is so firmware centric? Discovery matters, but what matters _most_ to devices is actually its runtime properties and runtime implementation - and I sure hope firmware has no active role in that! I really think this is backwards from the get go, it gives me a feeling of someone having spent way too much time in committee and too little time spent thinking about simple, proper kernel design and reusing existing terminology ... Also: + nd - kernel abi / device-model & ndctl - userspace helper library WTF is a 'kernel ABI'?? Thanks, Ingo