From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754685AbbDTJpp (ORCPT ); Mon, 20 Apr 2015 05:45:45 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:35236 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754084AbbDTJpn (ORCPT ); Mon, 20 Apr 2015 05:45:43 -0400 Date: Mon, 20 Apr 2015 02:45:39 -0700 From: Christoph Hellwig To: NeilBrown Cc: Christoph Hellwig , David Howells , Chris Mason , Al Viro , Josef Bacik , David Sterba , linux-cachefs@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA instead of ->bmap. Message-ID: <20150420094539.GA12622@infradead.org> References: <20150420052558.26554.97143.stgit@notabene.brown> <20150420052752.26554.52672.stgit@notabene.brown> <20150420060818.GA32675@infradead.org> <20150420162700.3e69c7db@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420162700.3e69c7db@notabene.brown> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 04:27:00PM +1000, NeilBrown wrote: > A worthwhile goal, but I certainly wouldn't consider pursuing it until what I > have submitted so far as been accepted - let's not reject "good" while > waiting for "perfect". It's still broken. You add conditional flag for the almost right (almost because the flag in the filesystem type needs to go) while leaving the broken option th default. So what you propose here is not good, it's at best just as bad as the old version because you don't remove broken code but add a lot more clutter at the same time.