From: Peter Griffin <peter.griffin@linaro.org>
To: Tejun Heo <tj@kernel.org>
Cc: Maxime Coquelin <maxime.coquelin@st.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
kernel@stlinux.com,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Patrice Chotard <patrice.chotard@st.com>
Subject: Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors
Date: Mon, 20 Apr 2015 14:04:26 +0100 [thread overview]
Message-ID: <20150420130426.GA906@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <20150417145558.GD1954@htj.duckdns.org>
Hi Tejun,
On Fri, 17 Apr 2015, Tejun Heo wrote:
> On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote:
> > Yes I can test, although not until Saturday as I only have remote
> > access to the board today & tomorrow and the hard drive isn't
> > plugged in.
>
> What's the status on this patch? Should I push it through
> for-4.1-fixes?
The layering violation which Brian identified does need fixing. However
please don't take this patch as it currently is, as it causes a NULL
ptr dereference.
I can send an updated version in a moment which: -
1) Fixes the conflict you will get when applying it for v4.1
(due to my "st_configure_oob must be called after IP is clocked" patch).
2) Fixes the crash which this patch introduces.
regards,
Peter.
next prev parent reply other threads:[~2015-04-20 13:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 18:59 [PATCH] ata: ahci_st: fixup layering violations / drvdata errors Brian Norris
2015-04-09 7:18 ` Maxime Coquelin
2015-04-09 9:43 ` Peter Griffin
2015-04-17 14:55 ` Tejun Heo
2015-04-20 13:04 ` Peter Griffin [this message]
2015-04-09 9:34 ` Sergei Shtylyov
2015-04-09 17:27 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420130426.GA906@griffinp-ThinkPad-X1-Carbon-2nd \
--to=peter.griffin@linaro.org \
--cc=computersforpeace@gmail.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).