From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752390AbbDTUfv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Apr 2015 16:35:51 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:34936 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751180AbbDTUfu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Apr 2015 16:35:50 -0400
Date: Mon, 20 Apr 2015 21:35:44 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Oleg Drokin <oleg.drokin@intel.com>, Neil Brown <neilb@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Filesystem Mailing List <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 01/24] lustre: rip the private symlink nesting limit out
Message-ID: <20150420203544.GM889@ZenIV.linux.org.uk>
References: <20150420181222.GK889@ZenIV.linux.org.uk>
 <1429553588-24764-1-git-send-email-viro@ZenIV.linux.org.uk>
 <343FC7D4-20A1-45D7-B86F-1BD2DC21F53A@dilger.ca>
 <20150420192253.GL889@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150420192253.GL889@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 20, 2015 at 08:22:53PM +0100, Al Viro wrote:
> On Mon, Apr 20, 2015 at 01:08:16PM -0600, Andreas Dilger wrote:
> > On Apr 20, 2015, at 12:12 PM, Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > > 
> > > From: Al Viro <viro@zeniv.linux.org.uk>
> > > 
> > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > 
> > Al, the patch itself looks good, thanks.
> > 
> > However, if this is applied at the start of the series it could
> > allow tests to easily cause a stack overflow during a bisection (I
> > don't think users would see a kernel in the middle of the series).
> > 
> > Could this be converted over to checking nd->link_count along with
> > the [02/24] patch until closer to the end of the series when the
> > recursion has been removed?
> 
> Er...  You do realize that struct nameidata is opaque for anything outside
> of fs/namei.c and has been that way for a while now?  Sure, we can export
> a helper that would return that and rip it out in the end of the series,
> but...

Actually, a cleaner solution would be to reorder that bunch (1--6) past
the link_path_walk() reorganization.  Done and force-pushed to the same
branch...