From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754662AbbDUNKM (ORCPT ); Tue, 21 Apr 2015 09:10:12 -0400 Received: from smtprelay0237.hostedemail.com ([216.40.44.237]:47721 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751842AbbDUNKG (ORCPT ); Tue, 21 Apr 2015 09:10:06 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3867:3868:3870:3873:5007:6119:6120:6261:7875:7901:7903:10004:10400:10848:10967:11026:11232:11658:11914:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pigs16_7515d173dc84b X-Filterd-Recvd-Size: 1557 Date: Tue, 21 Apr 2015 09:10:03 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Xunlei Pang , linux-kernel@vger.kernel.org, Juri Lelli , Xunlei Pang Subject: Re: [PATCH v6 2/3] sched/rt: Fix wrong SMP scheduler behavior for equal prio cases Message-ID: <20150421091003.16a591da@gandalf.local.home> In-Reply-To: <20150420234550.GA3182@worktop.meeting.verilan.com> References: <1429518168-7965-1-git-send-email-xlpang@126.com> <1429518168-7965-2-git-send-email-xlpang@126.com> <20150420105228.461e103c@gandalf.local.home> <20150420172048.GZ27490@worktop.programming.kicks-ass.net> <20150420134803.5446e32d@gandalf.local.home> <20150420234550.GA3182@worktop.meeting.verilan.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Apr 2015 01:45:50 +0200 Peter Zijlstra wrote: > Please don't try and be clever there :-) Task state can be misleading, > you might get a wakeup before you're running again, in which case you > never went to sleep. OK, point taken. > > Please use task_on_rq_queued(p) like all other sites. Agreed. -- Steve