From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754315AbbDUNi0 (ORCPT ); Tue, 21 Apr 2015 09:38:26 -0400 Received: from smtprelay0231.hostedemail.com ([216.40.44.231]:52839 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753740AbbDUNiW (ORCPT ); Tue, 21 Apr 2015 09:38:22 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:966:967:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2198:2199:2200:2393:2525:2553:2560:2563:2682:2685:2691:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4385:4886:5007:6119:6261:7875:7903:9025:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12295:12296:12438:12517:12519:12555:12740:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: spark60_48f17df13224b X-Filterd-Recvd-Size: 1793 Date: Tue, 21 Apr 2015 09:38:20 -0400 From: Steven Rostedt To: Ron Rechenmacher Cc: Christoph Hellwig , Subject: Re: [PATCH] tracing: Export key trace event symbols Message-ID: <20150421093820.6a565f58@gandalf.local.home> In-Reply-To: <55364052.4050707@fnal.gov> References: <553571C3.1060505@fnal.gov> <20150421061034.GA9253@infradead.org> <55363CDC.4000305@fnal.gov> <55364052.4050707@fnal.gov> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Apr 2015 07:19:30 -0500 Ron Rechenmacher wrote: > I see in the reference I mentioned below (https://patches.linaro.org/28821/), > and in the current mm source, that some tracepoint symbols are already EXPORTed, > but not _GPL. I do not know the fine points between "GPL-ed" and "non-GPL-ed" symbol > exporting. Would it make a difference if my patch proposed non-GPL exporting? The only reason there's non GPL exports for tracepoints is because tracepoints were used in header files, and called by static inlines like kfree() and such that were already exported non-gpl. I believe we removed all tracepoints from static inlines and headers because they were causing other problems (you don't want tracepoint code inlined all over the place, it bloats the kernel). I may look into cleaning up the kernel and removing the EXPORT_TRACEPOINT_SYMBOL(). -- Steve