From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754808AbbDUNX6 (ORCPT ); Tue, 21 Apr 2015 09:23:58 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48214 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbbDUNX4 (ORCPT ); Tue, 21 Apr 2015 09:23:56 -0400 Date: Tue, 21 Apr 2015 06:23:55 -0700 From: Christoph Hellwig To: Ron Rechenmacher Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] tracing: Export key trace event symbols Message-ID: <20150421132355.GA18161@infradead.org> References: <553571C3.1060505@fnal.gov> <20150421061034.GA9253@infradead.org> <55363CDC.4000305@fnal.gov> <20150421122202.GA8708@infradead.org> <55364CF4.2090600@fnal.gov> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55364CF4.2090600@fnal.gov> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2015 at 08:13:24AM -0500, Ron Rechenmacher wrote: > Hi Christoph, > > My module, and information about it, can be found at: > https://cdcvs.fnal.gov/redmine/projects/trace > https://cdcvs.fnal.gov/redmine/projects/trace/repository/show/src_module > with the header at > https://cdcvs.fnal.gov/redmine/projects/trace/repository/raw/include/trace.h And now send a patch including a rationale on why we need it. I haven't looked deep enough, but so far I can't see any real value add in it. > > It seems that you are the person that I have to convince in order to get > my patch accepted. Is this true? In the end you'll need to convince a maintainer to apply it. > Can you tell me how: > ./kernel/trace/power-traces.c:17:EXPORT_TRACEPOINT_SYMBOL_GPL(power_start); I can't find a tracepoint with that name in the current tree. > ./kernel/trace/power-traces.c:19:EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_idle); This one is used by the potentially modular intel_idle (now cpuids) driver, so it's exported for a reason. > should be allowed (how it fits with your definition of the Linux kernel below) and > my proposed EXPORTS not? > I hope that you will not suggest removing the above 2 exports. It's perfectly fine to remove unused exports, and we do it regularly