From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Laurent Vivier <laurent@vivier.eu>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firewire: add a parameter to force the speed of the devices.
Date: Tue, 21 Apr 2015 16:16:22 +0200 [thread overview]
Message-ID: <20150421161622.69637059@kant> (raw)
In-Reply-To: <553658A0.8060409@ladisch.de>
On Apr 21 Clemens Ladisch wrote:
> Laurent Vivier wrote:
> > I was trying to use my old iPod mini firewire (first generation) with
> > a new firewire card I put in my PC (VIA Technologies, Inc. VT6306/7/8),
> > but the iPod was not mounted and failed with the following error:
> > reading config rom failed: no ack
> > It appears that the configuration rom cannot be read after the
> > device max speed is set to something else than SCODE_100.
> >
> > According to the iPod configuration ROM, it should support SCODE_400.
> >
> > This patch adds a a parameter (force_speed) to the firewire-core module
> > to be able to set the max speed to use with the firewire devices.
>
> Why a module parameter? Why not automatically apply this workaround to
> this specific device?
I doubt that this iPod model needs the workaround. I suspect the
particular hardware combination needs one.
--
Stefan Richter
-=====-===== -=-- =-=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2015-04-21 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 0:36 [PATCH 0/2] Some firewire minor patches Laurent Vivier
2015-04-21 0:36 ` [PATCH 1/2] firewire: firewire is a big-endian bus Laurent Vivier
2015-04-21 1:04 ` Joe Perches
2015-04-21 14:13 ` Stefan Richter
2015-04-21 13:13 ` Stefan Richter
2015-04-21 16:04 ` Laurent Vivier
2015-04-21 0:36 ` [PATCH 2/2] firewire: add a parameter to force the speed of the devices Laurent Vivier
2015-04-21 14:03 ` Clemens Ladisch
2015-04-21 14:16 ` Stefan Richter [this message]
2015-04-21 14:33 ` Stefan Richter
2015-04-21 16:55 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421161622.69637059@kant \
--to=stefanr@s5r6.in-berlin.de \
--cc=clemens@ladisch.de \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).