From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757036AbbDVFkH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 01:40:07 -0400
Received: from mga09.intel.com ([134.134.136.24]:9692 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751307AbbDVFkE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 01:40:04 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,621,1422950400"; 
   d="scan'208";a="717273526"
Date: Wed, 22 Apr 2015 08:39:55 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: peterhuewe@gmx.de, tpmdd-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Marcel Selhorst <tpmdd@selhorst.net>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Tejun Heo <tj@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jianyu Zhan <nasa4836@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andrzej Hajda <a.hajda@samsung.com>, NeilBrown <neilb@suse.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH v2] tpm: enable PPI for TPM 2.0
Message-ID: <20150422053955.GA6764@intel.com>
References: <1429641062-14421-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <20150421195214.GA23833@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150421195214.GA23833@kroah.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 21, 2015 at 09:52:14PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote:
> > -#define to_tpm_chip(n) container_of(n, struct tpm_chip, vendor)
> > +#define to_tpm_chip(n) container_of(dev, struct tpm_chip, dev)
> 
> That doesn't look correct to me...

Oops, no it doesn't (things worked though because the local variable
where this was used was named as dev). Thanks for pointing this out.

> thanks,
> 
> greg k-h

/Jarkko