From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756843AbbDVLIV (ORCPT ); Wed, 22 Apr 2015 07:08:21 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50274 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbbDVLIS (ORCPT ); Wed, 22 Apr 2015 07:08:18 -0400 Date: Wed, 22 Apr 2015 12:08:08 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com, ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Message-ID: <20150422110808.GU22845@sirena.org.uk> References: <1429619636-25478-1-git-send-email-rf@opensource.wolfsonmicro.com> <1429619636-25478-4-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ULJ2Z7kCM1hyNsWd" Content-Disposition: inline In-Reply-To: <1429619636-25478-4-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ULJ2Z7kCM1hyNsWd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 21, 2015 at 01:33:51PM +0100, Richard Fitzgerald wrote: > + switch (arizona->type) { > + case WM8998: > + case WM1814: > + /* Some bits are shifted on WM8998, > + * rearrange to match the standard bit layout > + */ > + val[0] = ((val[0] & 0x60e0) >> 1) | > + ((val[0] & 0x1e00) >> 2) | > + (val[0] & 0x000f); > + break; Are you sure this approach is going to scale (and avoid confusion)? --ULJ2Z7kCM1hyNsWd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVN4EXAAoJECTWi3JdVIfQiD8H/i+Mcwpq04o9WCn7i2ImOUZJ tpjx1mQNwrCU6fTGW8T82VAEEhUxVyjWGmFC27GziGny0mzhxtCvEJBVEnTprr8y GXJ0ZXJRriAajV6jKuCc2PkziJlOZgfQ1pkIUlGedwf7h4AVKmKPxdhTze8+c5r1 TIrp//fAQLd8Z3O8ebuZabHcW7s2oITGeeb3S8+E39ub1reNZASrkZhuyk2j1K7m 8VKf63pbM1cCLQ0L/nsL8z+lsV+6jxLlHUYsaWkkFRQvrIoTnenB5zWXVD9I7I/A Xl04PYcaQ5qCddW6ROzapsmIuHxe0P1tpSZVig6AyvcMwfN5og2kmHX21FW/Mfs= =YKQo -----END PGP SIGNATURE----- --ULJ2Z7kCM1hyNsWd--