From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756939AbbDVLRx (ORCPT ); Wed, 22 Apr 2015 07:17:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52908 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756912AbbDVLRu (ORCPT ); Wed, 22 Apr 2015 07:17:50 -0400 Date: Wed, 22 Apr 2015 13:12:14 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern Subject: Re: [PATCHSET 00/10] perf tools: Assorted cleanup for TUI (v3) Message-ID: <20150422111214.GB27697@krava.redhat.com> References: <1429687101-4360-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429687101-4360-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2015 at 04:18:11PM +0900, Namhyung Kim wrote: > Hello, > > This patches are to cleanup TUI hists browser code for later work. I > moved hist_entry_diff and hist_entry_tui under an union in order to > reduce memory footprint of hist entry. Also split out hist browser > functions to make it easier to read. > > * changed in v3) > - save necessary info in hist_browser (Arnaldo) > - rename to struct popup_action (Arnaldo) > - split popup registration and callback (Arnaldo) > - move TUI-specific fields out of map_symbol Acked-by: Jiri Olsa thanks, jirka