From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757377AbbDVNjO (ORCPT ); Wed, 22 Apr 2015 09:39:14 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22052 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756714AbbDVNjM (ORCPT ); Wed, 22 Apr 2015 09:39:12 -0400 Date: Wed, 22 Apr 2015 16:39:00 +0300 From: Dan Carpenter To: Greg Kroah-Hartman Cc: Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] kdbus: checking for IS_ERR() instead of NULL Message-ID: <20150422133900.GB29383@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "e->user" is never assigned an ERR_PTR(). It can be set to NULL so I assume that is what is intended here. Signed-off-by: Dan Carpenter diff --git a/ipc/kdbus/queue.c b/ipc/kdbus/queue.c index a449464..21fce62 100644 --- a/ipc/kdbus/queue.c +++ b/ipc/kdbus/queue.c @@ -637,7 +637,7 @@ int kdbus_queue_entry_move(struct kdbus_queue_entry *e, lockdep_assert_held(&src->lock); lockdep_assert_held(&dst->lock); - if (WARN_ON(IS_ERR(e->user)) || WARN_ON(list_empty(&e->entry))) + if (WARN_ON(!e->user) || WARN_ON(list_empty(&e->entry))) return -EINVAL; if (src == dst) return 0;