From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965690AbbDVPaK (ORCPT ); Wed, 22 Apr 2015 11:30:10 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:33499 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756453AbbDVPaH (ORCPT ); Wed, 22 Apr 2015 11:30:07 -0400 Date: Wed, 22 Apr 2015 11:30:02 -0400 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org, richard@nod.at, fweisbec@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys Message-ID: <20150422153002.GB10738@htj.duckdns.org> References: <1429446154-10660-1-git-send-email-cyphar@cyphar.com> <1429446154-10660-2-git-send-email-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429446154-10660-2-git-send-email-cyphar@cyphar.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ooh, just one more thing. On Sun, Apr 19, 2015 at 10:22:31PM +1000, Aleksa Sarai wrote: > +/** > + * for_each_subsys_which - filter for_each_subsys with a bitmask > + * @ss_mask: the bitmask > + * @ss: the iteration cursor > + * @ssid: the index of @ss, CGROUP_SUBSYS_COUNT after reaching the end > + * > + * The block will only run for cases where the ssid-th bit (1 << ssid) of > + * mask is set to 1. > + */ > +#define for_each_subsys_which(ss_mask, ss, ssid) \ > + for_each_subsys((ss), (ssid)) \ > + if ((ss_mask) & (1 << (ssid))) > + This isn't completely consistent but we tend to put the cursors in front of what's being iterated. e.g. for_each_css(css, ssid, cgrp) for_each_set_bit(bit, addr, size) Following the pattern, for_each_subsys_which() prolly should do for_each_subsys_which(ss, ssid, ss_mask) rather than the other way around. Thanks. -- tejun