From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965642AbbD1Mq2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Apr 2015 08:46:28 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:53572 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965421AbbD1Mq1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Apr 2015 08:46:27 -0400
Date: Tue, 28 Apr 2015 05:46:24 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@ml01.01.org, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
        Jens Axboe <axboe@fb.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [Linux-nvdimm] [PATCH 01/21] e820, efi: add ACPI 6.0 persistent
 memory types
Message-ID: <20150428124624.GA20681@infradead.org>
References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com>
 <20150418013519.25237.16129.stgit@dwillia2-desk3.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150418013519.25237.16129.stgit@dwillia2-desk3.amr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 17, 2015 at 09:35:19PM -0400, Dan Williams wrote:
> diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
> index c52d7540dc05..cd8b7485e396 100644
> --- a/arch/ia64/kernel/efi.c
> +++ b/arch/ia64/kernel/efi.c
> @@ -1227,6 +1227,7 @@ efi_initialize_iomem_resources(struct resource *code_resource,
>  			case EFI_RUNTIME_SERVICES_CODE:
>  			case EFI_RUNTIME_SERVICES_DATA:
>  			case EFI_ACPI_RECLAIM_MEMORY:
> +			case EFI_PERSISTENT_MEMORY:
>  			default:
>  				name = "reserved";

You probably want pmem as name here..

> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> index 11cc7d54ec3f..410af501a941 100644
> --- a/arch/x86/kernel/e820.c
> +++ b/arch/x86/kernel/e820.c
> @@ -137,6 +137,8 @@ static void __init e820_print_type(u32 type)
>  	case E820_RESERVED_KERN:
>  		printk(KERN_CONT "usable");
>  		break;
> +	case E820_PMEM:
> +	case E820_PRAM:
>  	case E820_RESERVED:
>  		printk(KERN_CONT "reserved");
>  		break;
> @@ -149,9 +151,6 @@ static void __init e820_print_type(u32 type)
>  	case E820_UNUSABLE:
>  		printk(KERN_CONT "unusable");
>  		break;
> -	case E820_PRAM:
> -		printk(KERN_CONT "persistent (type %u)", type);
> -		break;

Please keep this printk, and add the new E820_PMEM case to it as well.

> +static bool do_mark_busy(u32 type, struct resource *res)
> +{
> +	if (res->start < (1ULL<<20))
> +		return true;
> +
> +	switch (type) {
> +	case E820_RESERVED:
> +	case E820_PRAM:
> +	case E820_PMEM:
> +		return false;
> +	default:
> +		return true;
> +	}
> +}

Please add a comment explaining the choices once you start refactoring
this.  Especially the address check is black magic..