From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966345AbbD2RI7 (ORCPT ); Wed, 29 Apr 2015 13:08:59 -0400 Received: from smtprelay0170.hostedemail.com ([216.40.44.170]:34076 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965184AbbD2RI4 (ORCPT ); Wed, 29 Apr 2015 13:08:56 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3873:3874:4321:5007:6261:7875:7904:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12050:12296:12438:12517:12519:12663:12740:13069:13311:13357:14040:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: paste75_3097be6e97643 X-Filterd-Recvd-Size: 2324 Date: Wed, 29 Apr 2015 13:08:52 -0400 From: Steven Rostedt To: Shreyas B Prabhu Cc: Preeti Murthy , Paul McKenney , LKML , Ingo Molnar , aneesh.kumar@linux.vnet.ibm.com, Preeti U Murthy Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus Message-ID: <20150429130852.487100d9@gandalf.local.home> In-Reply-To: <5540FFAE.2050502@linux.vnet.ibm.com> References: <1430236283-29360-1-git-send-email-shreyas@linux.vnet.ibm.com> <1430236283-29360-3-git-send-email-shreyas@linux.vnet.ibm.com> <5540EF78.8000409@linux.vnet.ibm.com> <20150429111812.60b697c6@gandalf.local.home> <5540FFAE.2050502@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2015 21:28:38 +0530 Shreyas B Prabhu wrote: > > > On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote: > > On Wed, 29 Apr 2015 20:19:28 +0530 > > Shreyas B Prabhu wrote: > > > >> IIUC there is no existing macro which can both add a condition and > >> override printk format, hence the fall back to TRACE_EVENT_CONDITION. > > > > Hmm, want me to send you a patch that changes that? > > > I am not sure if its worth the effort now. It doesn't look like any > other trace point apart from the above use case will benefit from it. > Only smbus_write and smbus_reply seem to come close. But even they need > separate TP_fast_assign. It shouldn't be a problem to implement. But I'm currently cleaning up those files, and any changes will cause nasty conflicts. Lets do this. Push the current changes as is, and when I get around to adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use it. -- Steve