linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Trevor Cordes <trevor@tecnopolis.ca>
Cc: linux-kernel@vger.kernel.org,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Boyer <jwboyer@redhat.com>
Subject: Re: regression in ktime.h circa 3.16.0-rc5+ breaks lirc irsend, bad commit 166afb64511
Date: Thu, 30 Apr 2015 11:53:45 +0100	[thread overview]
Message-ID: <20150430115345.1204406e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20150429232721.59b89cb1@pog.tecnopolis.ca>

> > Obviously my patch isn't the real solution, the real solution is to
> > make the new function calls use a consistent 64-bit type, or figure
> > out what in my code path is calling these functions and check it for
> > value sanity.

I would be tempted to do both computations and print then inputs as well
as do a WARN_ON when they differ. That will give you a stack trace of the
offender, and providing you return the "correct" value you can see how it
continues functioning afterwards.

Alan

  reply	other threads:[~2015-04-30 10:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 16:57 regression in ktime.h circa 3.16.0-rc5+ breaks lirc irsend, bad commit 166afb64511 Trevor Cordes
2015-04-30  4:27 ` Trevor Cordes
2015-04-30 10:53   ` One Thousand Gnomes [this message]
2015-04-30 16:35   ` John Stultz
2015-05-01 10:02     ` Trevor Cordes
2015-05-01 17:31       ` John Stultz
2015-05-01 18:29         ` Nicolas Pitre
2015-05-01 18:51           ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430115345.1204406e@lxorguk.ukuu.org.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=john.stultz@linaro.org \
    --cc=jwboyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=trevor@tecnopolis.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).