From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <williams@redhat.com>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH][RT] xfs: Disable preemption when grabbing all icsb counter locks
Date: Thu, 30 Apr 2015 14:32:26 -0400 [thread overview]
Message-ID: <20150430143226.061202df@gandalf.local.home> (raw)
In-Reply-To: <20150430180721.GX5029@twins.programming.kicks-ass.net>
On Thu, 30 Apr 2015 20:07:21 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, Apr 30, 2015 at 12:33:03PM -0400, Steven Rostedt wrote:
> > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> > index 51435dbce9c4..dbaa1ce3f308 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -1660,6 +1660,12 @@ xfs_icsb_lock_all_counters(
> > xfs_icsb_cnts_t *cntp;
> > int i;
> >
> > + /*
> > + * In PREEMPT_RT, preemption is not disabled here, and it
> > + * must be to take the xfs_icsb_lock_cntr.
> > + */
> > + preempt_disable_rt();
> > +
> > for_each_online_cpu(i) {
> > cntp = (xfs_icsb_cnts_t *)per_cpu_ptr(mp->m_sb_cnts, i);
> > xfs_icsb_lock_cntr(cntp);
> > @@ -1677,6 +1683,8 @@ xfs_icsb_unlock_all_counters(
> > cntp = (xfs_icsb_cnts_t *)per_cpu_ptr(mp->m_sb_cnts, i);
> > xfs_icsb_unlock_cntr(cntp);
> > }
> > +
> > + preempt_enable_rt();
> > }
>
> The irony, this is distinctly non deterministic code you're putting
> under a RT specific preempt_disable ;-)
I know :-(
Unfortunately, a RT behaving fix would be much more invasive and would
probably require the help of the xfs folks. For now, this just prevents
a live lock that can happen and halt the system, where it becomes
deterministic catastrophe.
-- Steve
next prev parent reply other threads:[~2015-04-30 18:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 16:33 [PATCH][RT] xfs: Disable preemption when grabbing all icsb counter locks Steven Rostedt
2015-04-30 18:07 ` Peter Zijlstra
2015-04-30 18:32 ` Steven Rostedt [this message]
2015-04-30 18:40 ` Austin Schuh
2015-04-30 19:07 ` Steven Rostedt
2015-04-30 18:33 ` Christoph Hellwig
2015-04-30 18:36 ` Steven Rostedt
2015-05-04 0:48 ` Dave Chinner
2015-05-04 14:14 ` Steven Rostedt
2015-05-13 15:36 ` [PATCH][RT] xfs: Disable percpu SB on PREEMPT_RT_FULL Steven Rostedt
2015-05-14 16:32 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430143226.061202df@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).