From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbbEADYM (ORCPT ); Thu, 30 Apr 2015 23:24:12 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:49069 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbbEADYI (ORCPT ); Thu, 30 Apr 2015 23:24:08 -0400 Date: Fri, 1 May 2015 11:24:04 +0800 From: Herbert Xu To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 01/11] drivers/crypto: include for modular caam code Message-ID: <20150501032404.GC371@gondor.apana.org.au> References: <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com> <1430444867-22342-2-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430444867-22342-2-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2015 at 09:47:37PM -0400, Paul Gortmaker wrote: > This file is built off of a tristate Kconfig option and also contains > modular function calls so it should explicitly include module.h to > avoid compile breakage during header shuffles done in the future. > > Cc: Herbert Xu > Cc: "David S. Miller" > Signed-off-by: Paul Gortmaker Please post patches to linux-crypto@vger.kernel.org if you want them to go through the crypto tree. Also it actually gets module.h through caam/compat.h. So your patch is unnecessary. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt