From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990AbbEAOQL (ORCPT ); Fri, 1 May 2015 10:16:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56229 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbbEAOQJ (ORCPT ); Fri, 1 May 2015 10:16:09 -0400 Date: Fri, 1 May 2015 16:16:04 +0200 From: "gregkh@linuxfoundation.org" To: Alan Cox Cc: One Thousand Gnomes , "Gujulan Elango, Hari Prasath (H.)" , "devel@driverdev.osuosl.org" , "somyaanand214@gmail.com" , "iskaranth@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: i2o: Remove unwanted semicolon Message-ID: <20150501141604.GB11584@kroah.com> References: <20150423133751.GA10268@IND12F0122> <1429801768.2878.361.camel@linux.intel.com> <20150430141406.GA8230@kroah.com> <20150430232548.0ee0a0a5@lxorguk.ukuu.org.uk> <20150501074103.GA19840@kroah.com> <1430472480.2878.397.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430472480.2878.397.camel@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 10:28:00AM +0100, Alan Cox wrote: > On Fri, 2015-05-01 at 09:41 +0200, gregkh@linuxfoundation.org wrote: > > On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: > > > On Thu, 30 Apr 2015 16:14:06 +0200 > > > "gregkh@linuxfoundation.org" wrote: > > > > > > > On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: > > > > > On Thu, 2015-04-23 at 13:43 +0000, Gujulan Elango, Hari Prasath (H.) > > > > > wrote: > > > > > > This patch removes unwanted semicolon around close braces of code blocks > > > > > > > > > > > > > > > The i2o driver moved into staging ready to be deleted unless someone > > > > > steps up with hardware willing to maintain it (which is rather > > > > > unlikely). > > > > > > > > I think it's now time to delete these, want me to do that for 4.2? I > > > > can queue that up in my tree now, so that we don't see any more cleanup > > > > patches being made for them? > > > > > > Yeah I think it can go.... > > > > I was about to delete it, but what about drivers/scsi/dpt/dpti_i2o.* ? > > Should that be removed as well? > > Possibly but that ought to go via staging and really is one for the SCSI > folks to call. The dpt_i2o was a bit more common than i2o proper. But if the staging i2o core is removed, doesn't that mean that this driver will stop working? It uses code in uapi i2o.h, which I'm guessing is implemented in the staging i2o core. thanks, greg k-h