From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbbEASFo (ORCPT ); Fri, 1 May 2015 14:05:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59980 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbbEASFk (ORCPT ); Fri, 1 May 2015 14:05:40 -0400 Date: Fri, 1 May 2015 20:05:30 +0200 From: Greg Kroah-Hartman To: "Simmons, James A." Cc: "'Julia Lawall'" , Oleg Drokin , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "HPDD-discuss@lists.01.org" Subject: Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Message-ID: <20150501180530.GA26281@kroah.com> References: <1430495482-933-1-git-send-email-Julia.Lawall@lip6.fr> <1430495482-933-11-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 05:38:49PM +0000, Simmons, James A. wrote: > >From: Julia Lawall > > > >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by > >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. > > Nak: James Simmons > > A simple replace will not work. The OBD_ALLOC and OBD_FREE functions allocate memory > anywhere from one page to 4MB in size. OBD_FREE() just calls kfree(), it does not allocate any memory, so that replacement is always ok. thanks, greg k-h