From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437AbbEBIOe (ORCPT ); Sat, 2 May 2015 04:14:34 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43276 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbbEBIOb (ORCPT ); Sat, 2 May 2015 04:14:31 -0400 Date: Sat, 2 May 2015 11:14:16 +0300 From: Dan Carpenter To: "Drokin, Oleg" Cc: Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Julia Lawall , "HPDD-discuss@lists.01.org" , "Simmons, James A." Subject: Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Message-ID: <20150502081416.GG16501@mwanda> References: <1430495482-933-1-git-send-email-Julia.Lawall@lip6.fr> <1430495482-933-11-git-send-email-Julia.Lawall@lip6.fr> <20150501200221.GF14154@mwanda> <9f81478864bc422c9a59cddbaa723052@EXCHCS32.ornl.gov> <20150501204930.GB2265@kroah.com> <20150501205835.GA2692@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 09:13:11PM +0000, Drokin, Oleg wrote: > >> The patch was submitted. > >> But it depends on a symbol that's not exported. > >> I was not able to change that. > >> http://www.spinics.net/lists/linux-mm/msg83997.html > > > > But you were given a hint on how to change that :) > > Well, the hint amounted to "don't do vmalloc if you cannot live with the > GFP_KERNEL" allocations. > Which email is that? I only see where David says to implement vmalloc_node_gfp() and the talk was about if that makes sense from a style perspective and then dies. Anyway, this only seems to affect ptlrpc_alloc_rqbd() since I think that's the only place which calls OBD_CPT_ALLOC_PTR(). The rest can use __vmalloc(). regards, dan carpenter