From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: mingo@redhat.com, ak@linux.intel.com,
Michael Ellerman <mpe@ellerman.id.au>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 4/4] perf: Create aliases for PMU events
Date: Sat, 2 May 2015 17:38:14 +0200 [thread overview]
Message-ID: <20150502153814.GA21242@krava.redhat.com> (raw)
In-Reply-To: <1430463941-26109-5-git-send-email-sukadev@linux.vnet.ibm.com>
On Fri, May 01, 2015 at 12:05:41AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +
> +static int pmu_add_cpu_aliases(char *cpustr, void *data)
> +{
> + struct list_head *head = (struct list_head *)data;
> + struct perf_pmu_alias *alias;
> + int i;
> + struct perf_pmu_event *events_table, *event;
> + struct parse_events_term *term;
> +
> + events_table = arch_get_events_table(cpustr);
> + if (!events_table)
> + return 0;
> +
> + for (i = 0; events_table[i].name != NULL; i++) {
> + event = &events_table[i];
> +
> + alias = malloc(sizeof(*alias));
> + if (!alias)
> + return -ENOMEM;
> +
> + term = malloc(sizeof(*term));
> + if (!term) {
> + /*
> + * TODO: cleanup aliases allocated so far?
> + */
> + free(alias);
> + return -ENOMEM;
> + }
> +
> + /* ->config is not const; cast to override */
> + term->config = (char *)"event";
> + term->val.num = event->code;
> + term->type_val = PARSE_EVENTS__TERM_TYPE_NUM;
> + term->type_term = PARSE_EVENTS__TERM_TYPE_USER;
> + INIT_LIST_HEAD(&term->list);
> + term->used = 0;
hum, so I checked and for x86 the 'struct perf_pmu_event::code' is not enough
Andi introduced following JSON notation for event:
[
{
"EventCode": "0x00",
"UMask": "0x01",
"EventName": "INST_RETIRED.ANY",
"BriefDescription": "Instructions retired from execution.",
"PublicDescription": "Instructions retired from execution.",
"Counter": "Fixed counter 1",
"CounterHTOff": "Fixed counter 1",
"SampleAfterValue": "2000003",
"MSRIndex": "0",
"MSRValue": "0",
"TakenAlone": "0",
"CounterMask": "0",
"Invert": "0",
"AnyThread": "0",
"EdgeDetect": "0",
"PEBS": "0",
"PRECISE_STORE": "0",
"Errata": "null",
"Offcore": "0"
}
which gets processed/translated into string of terms "event=..,umask=,..."
which is used to create alias 'struct perf_pmu_alias'
please check Andi's patch:
[PATCH v9 04/11] perf, tools: Add support for reading JSON event files
function json_events
I wonder we should stay with JSON description during build time
translate all (for architecture) events into strings in term format
"event=..,umask=,...' and this array of string would be loaded
as aliases in runtime
so we would have architecture specific tool that would translate
JSON events data into array of strings (events in terms form for
given architecture) which would get compiled into perf
I personaly like having set of event files in JSON notation
rather than having them directly in C structure
thoughts?
jirka
next prev parent reply other threads:[~2015-05-02 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 7:05 [RFC][PATCH 0/4] perf: Enable symbolic event names Sukadev Bhattiprolu
2015-05-01 7:05 ` [RFC][PATCH 1/4] perf: Create a table of Power7 PMU events Sukadev Bhattiprolu
2015-05-01 7:05 ` [RFC][PATCH 2/4] perf: Create a table of Power8 " Sukadev Bhattiprolu
2015-05-01 7:05 ` [RFC][PATCH 3/4] perf/powerpc: Move mfspr and friends to header file Sukadev Bhattiprolu
2015-05-01 7:05 ` [RFC][PATCH 4/4] perf: Create aliases for PMU events Sukadev Bhattiprolu
2015-05-02 7:04 ` Vineet Gupta
2015-05-02 15:38 ` Jiri Olsa [this message]
2015-05-04 11:44 ` Andi Kleen
2015-05-02 7:02 ` [RFC][PATCH 0/4] perf: Enable symbolic event names Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502153814.GA21242@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).