From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753157AbbEBX7V (ORCPT <rfc822;w@1wt.eu>);
	Sat, 2 May 2015 19:59:21 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:50409 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752801AbbEBX7L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 2 May 2015 19:59:11 -0400
Date: Sat, 2 May 2015 16:59:10 -0700
From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Kenneth Westfield <kwestfie@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH 08/14] ASoC: qcom: add dma channel control offset to
 variant data
Message-ID: <20150502235909.GD27804@kwestfie-linux.qualcomm.com>
Mail-Followup-To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org
References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org>
 <1430414252-11210-1-git-send-email-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1430414252-11210-1-git-send-email-srinivas.kandagatla@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 30, 2015 at 06:17:32PM +0100, Srinivas Kandagatla wrote:
> This patch adds ability to pass dma channel control bits start offset, which
> differ in differnet qcom SOCs. On apq8016 dma channel control bits start
> after an offset of 1.

Alot of the SOCs have similar small differences in the LPASS register
map.  For now, this is fine, but we will probably want to add some
system of quirks to handle these differences; as more SOCs drivers
are implemented.

>  sound/soc/qcom/lpass-platform.c | 2 +-
>  sound/soc/qcom/lpass.h          | 6 ++++++
>  2 files changed, 7 insertions(+), 1 deletion(-)

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project