On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote: > + } > + > + codec->dapm.bias_level = level; > + return 0; > +} This assignment was factored out into the core last week, I'll fix up for that. > + if (dev->of_node) { > + const struct of_device_id *of_id; > + > + of_id = of_match_device(tas571x_of_match, dev); > + if (of_id) > + priv->chip = of_id->data; > + } Doesn't of_match_device() do the right thing with devices not registered from DT?