On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: > + if (!drvdata->variant->no_osr_clk) { > + ret = clk_prepare_enable(drvdata->mi2s_osr_clk[dai->id]); Can we do this by checking to see if the clock is set to IS_ERR() instead? That's what we're doing elsewhere for possibly optional clocks.