From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753409AbbEDNQa (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 May 2015 09:16:30 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49357 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753190AbbEDNQK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 May 2015 09:16:10 -0400
Date: Mon, 4 May 2015 13:26:19 +0100
From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Patrick Lai <plai@codeaurora.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Kenneth Westfield <kwestfie@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-msm@vger.kernel.org
Message-ID: <20150504122619.GS15510@sirena.org.uk>
References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org>
 <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="mln0rGgUGuXEqmuI"
Content-Disposition: inline
In-Reply-To: <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org>
X-Cookie: Keep refrigerated.
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 86.189.253.62
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass
 variant
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--mln0rGgUGuXEqmuI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote:

> +	if (!drvdata->variant->no_osr_clk) {
> +		ret = clk_prepare_enable(drvdata->mi2s_osr_clk[dai->id]);

Can we do this by checking to see if the clock is set to IS_ERR()
instead?  That's what we're doing elsewhere for possibly optional
clocks.

--mln0rGgUGuXEqmuI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVR2VqAAoJECTWi3JdVIfQe9AH/RWaolT9nl6TTzAwhZWC9I/B
nRqOQhDLNcO8gUWKGxHB/6UVVEECb74nMHUvsgyeLDRJ9D6ZBL5Mdkks4lG4N2hJ
2F8PJPkJDXIQroRlUL2IN5zEgk+1hEp/XCG3HzaZQ5+gV7+2LO8OS7jkIYC/FsMX
m1bM4hk5kWCsLNzcBg09+MTxIBDt8EUGSL6VMcsGZgAHywh9+QP1beEiqPLJqtYv
sVvsV3fwLrDV45W3CGz7kEOSNp6mwPdgd/OtcBs5cXXKgij0CRYNIlJAi9jTo188
yGLSIQ8hOOSYq2iZymNT/WeAKFwp9Eu6tVTpYpmroBk0SYTj3Ks1laRFTm46Q98=
=eE4i
-----END PGP SIGNATURE-----

--mln0rGgUGuXEqmuI--