linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Pavel Machek <pavel@ucw.cz>, Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kai Vehmanen <kvehmanen@nosignal.fi>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HSI: cmt_speech: fix timestamp interface
Date: Mon, 4 May 2015 16:02:54 +0200	[thread overview]
Message-ID: <20150504140254.GB13164@earth> (raw)
In-Reply-To: <1429204430-26807-1-git-send-email-sre@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Hi Arnd,

On Thu, Apr 16, 2015 at 07:13:50PM +0200, Sebastian Reichel wrote:
> The user interface for timestamps in the new cmt_speech
> driver is broken in multiple ways:
> 
> - The layout is incompatible between 32-bit and 64-bit user
>   space, because of the size differences in 'struct timespec'.
>   This means that the driver can not work when used with 32-bit
>   user space on a 64-bit kernel.
> 
> - As there are plans to change 32-bit user space to use
>   a 64-bit time_t type in the future, it will also be
>   incompatible with new 32-bit user space.
> 
> To keep support for the user space tools written for this driver (which
> have lived many years out-of-tree), the interface has been hardened to
> unsigned 32-bit values.

Are you fine with this patch? I would like to queue it for 4.1-rc.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-05-04 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 11:59 [RFC, PATCH] HSI: cmt_speech: fix timestamp interface Arnd Bergmann
2015-04-10 13:36 ` Sebastian Reichel
2015-04-10 20:11   ` Arnd Bergmann
2015-04-16 17:13     ` [PATCH] " Sebastian Reichel
2015-04-23 13:37       ` Thomas Gleixner
2015-05-04 14:04         ` Sebastian Reichel
2015-05-04 14:02       ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504140254.GB13164@earth \
    --to=sre@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=arnd@arndb.de \
    --cc=kvehmanen@nosignal.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).