From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbbEFFnd (ORCPT ); Wed, 6 May 2015 01:43:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51269 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbbEFFna (ORCPT ); Wed, 6 May 2015 01:43:30 -0400 Date: Tue, 5 May 2015 22:43:28 -0700 From: Kenneth Westfield To: Srinivas Kandagatla Cc: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [alsa-devel] [RFC PATCH 03/14] ASoC: qcom: move ipq806x specific bits out of lpass driver. Message-ID: <20150506054328.GC5639@kwestfie-linux.qualcomm.com> Mail-Followup-To: Srinivas Kandagatla , Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org> <1430414213-10997-1-git-send-email-srinivas.kandagatla@linaro.org> <20150502235738.GB27804@kwestfie-linux.qualcomm.com> <20150505051913.GA12961@kwestfie-linux.qualcomm.com> <55486E83.9030308@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55486E83.9030308@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2015 at 12:17:23AM -0700, Srinivas Kandagatla wrote: > On 05/05/15 06:19, Kenneth Westfield wrote: > >>>> >+enum lpaif_i2s_ports { > >>>> >+ LPAIF_I2S_PORT_MIN = 0, > >>>> >+ > >>>> >+ LPAIF_I2S_PORT_CODEC_SPK = 0, > >>>> >+ LPAIF_I2S_PORT_CODEC_MIC = 1, > >>>> >+ LPAIF_I2S_PORT_SEC_SPK = 2, > >>>> >+ LPAIF_I2S_PORT_SEC_MIC = 3, > >>>> >+ LPAIF_I2S_PORT_MI2S = 4, > >>>> >+ > >>>> >+ LPAIF_I2S_PORT_MAX = 4, > >>>> >+ LPAIF_I2S_PORT_NUM = 5, > >>>> >+}; > >>> > >>>These port mappings here... > >>> > >>>> >+enum lpaif_irq_ports { > >>>> >+ LPAIF_IRQ_PORT_MIN = 0, > >>>> >+ > >>>> >+ LPAIF_IRQ_PORT_HOST = 0, > >>>> >+ LPAIF_IRQ_PORT_ADSP = 1, > >>>> >+ > >>>> >+ LPAIF_IRQ_PORT_MAX = 2, > >>>> >+ LPAIF_IRQ_PORT_NUM = 3, > >>>> >+}; > >>> > >>>...here... > >>> > >>>> >+enum lpaif_dma_channels { > >>>> >+ LPAIF_RDMA_CHAN_MIN = 0, > >>>> >+ > >>>> >+ LPAIF_RDMA_CHAN_MI2S = 0, > >>>> >+ LPAIF_RDMA_CHAN_PCM0 = 1, > >>>> >+ LPAIF_RDMA_CHAN_PCM1 = 2, > >>>> >+ > >>>> >+ LPAIF_RDMA_CHAN_MAX = 4, > >>>> >+ LPAIF_RDMA_CHAN_NUM = 5, > >>>> >+}; > >>> > >>>...and here can be SOC-specific. Should move them to the SOC-specific > >>>files. > >Expanding on this, the I2S port mappings for the APQ8016 should replace > >the ones defined above with the constants you refer to in > >dt-bindings/sound/apq8016.h: > > MI2S_PRIMARY > > MI2S_SECONDARY > > etc. > > > >Maybe defining a corresponding ipq806x.h in the same directory, and > >moving the above definitions there? > > As you pointed out i2s ports definitions can be moved to > dt-bindings/soc/ipq806x.h but the channels can be directly defined > in lpass-ipq806x.c as there would be no DT consumers for these > defines > anyway. Moving the I2S ports to dt-bindings and the other definitions to their SOC-specific source files works for me. -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project