From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752417AbbEFR3V (ORCPT ); Wed, 6 May 2015 13:29:21 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53269 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbbEFR3T (ORCPT ); Wed, 6 May 2015 13:29:19 -0400 Date: Wed, 6 May 2015 18:28:46 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: linux-arm-kernel@lists.infradead.org, Maxime Ripard , Rob Herring , Kumar Gala , s.hauer@pengutronix.de, Greg Kroah-Hartman , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org Message-ID: <20150506172846.GC22845@sirena.org.uk> References: <1427752492-17039-1-git-send-email-srinivas.kandagatla@linaro.org> <1427752670-17219-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QRZRoILo0Pq4YpTd" Content-Disposition: inline In-Reply-To: <1427752670-17219-1-git-send-email-srinivas.kandagatla@linaro.org> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 04/10] eeprom: Add a simple EEPROM framework for eeprom consumers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QRZRoILo0Pq4YpTd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 30, 2015 at 10:57:50PM +0100, Srinivas Kandagatla wrote: > + > + for (i = 0; i < cell->nblocks; i++) { > + rc = regmap_raw_read(eeprom->regmap, cell->blocks[i].offset, > + buf + offset, cell->blocks[i].count); I *think* this is probably OK but please double check that the count here is in bytes rather than words, it's a bit confusing since I'd read a count as being in words. Otherwise I think the regmap usage here all looks good. --QRZRoILo0Pq4YpTd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVSk9OAAoJECTWi3JdVIfQuNkH/RnXfz7KyQ5kGvUyl3+gaXeJ XwnfC+bEF1j2tRN6FTe/0w39Ll50q55jrTHgWHbTa3y0P1eKg7HXznlya/dHXy6S dgDjePF1thLsAWER3qeyW/jWNATd/sf0ZQzJuISX94KbLklkgxSVfkSDh1JdlPwl XPzFQzfm5qccmdc+LRu0sElChMPY11c+PXSNe1qHl+hoZVb5aKAiLzJj0TQl43xk AKJwA04mcEbj0xDKOXS6Dl4SRqMJiZrmEK9cYtwdLRW4A+r1yGwIwPxSHk8Mssxl vQ/mqBcpx56HKXeio46C/uJVgIX7toJlxmbSmQUT2B4YO5zm70Kbb8RgxEHxKZI= =wNz3 -----END PGP SIGNATURE----- --QRZRoILo0Pq4YpTd--