From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754883AbbEGKgY (ORCPT ); Thu, 7 May 2015 06:36:24 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:54874 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbbEGKgW (ORCPT ); Thu, 7 May 2015 06:36:22 -0400 Date: Thu, 7 May 2015 16:05:16 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ananth N Mavinakayanahalli , Anton Arapov , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Ingo Molnar , Jan Willeke , Jim Keniston , Mark Wielaard , Pratyush Anand , linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] uprobes/x86: Introduce arch_uretprobe_is_alive() Message-ID: <20150507103516.GD30396@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150504124835.GA22462@redhat.com> <20150504124914.GA22512@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150504124914.GA22512@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15050710-0025-0000-0000-00000172AADB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Oleg Nesterov [2015-05-04 14:49:14]: > Add the x86-specific arch_uretprobe_is_alive() helper and define its > "weak" version for other architectures. > > It returns true if the stack frame mangled by prepare_uretprobe() is > still on stack. So if it returns false, we know that the probed func > has already returned. > > TODO: this assumes that the probed app can't use multiple stacks (say > sigaltstack). We will try to improve this logic later. > > Signed-off-by: Oleg Nesterov Looks good to me. Acked-by: Srikar Dronamraju > --- -- Thanks and Regards Srikar Dronamraju