linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: perf: WARNING perfevents: irq loop stuck!
Date: Fri, 8 May 2015 09:53:47 +0200	[thread overview]
Message-ID: <20150508075347.GB5403@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1505080018140.26907@vincent-weaver-1.umelst.maine.edu>


* Vince Weaver <vincent.weaver@maine.edu> wrote:

> On Fri, 1 May 2015, Ingo Molnar wrote:
> 
> > So 0000fffffffffffe corresponds to 2 events left until overflow, 
> > right? And on Haswell we don't set x86_pmu.limit_period AFAICS, so we 
> > allow these super short periods.
> > 
> > Maybe like on Broadwell we need a quirk on Nehalem/Haswell as well, 
> > one similar to bdw_limit_period()? Something like the patch below?
> > 
> > Totally untested and such. I picked 128 because of Broadwell, but 
> > lower values might work as well. You could try to increase it to 3 and 
> > upwards and see which one stops triggering stuck NMI loops?
> 
> I spent a lot of time trying to come up with a test case that 
> triggered this more reliably but failed.
> 
> It definitely is an issue with PMC0 being -2 causing the PMC0 bit in 
> the status register getting stuck and no clearing.  Often there is 
> also a PEBS event active at the same time but that might be 
> coincidence.
> 
> With your patch applied I can't trigger the issue. I haven't tried 
> narrowing down the exact value yet.

So how about I change it from 128U to 2U and apply it upstream?

I.e. use the minimal threshold that we have observed to cause 
problems. That way should it ever trigger in different circumstances 
we'll eventually trigger it or hear about it.

Thanks,

	Ingo

  reply	other threads:[~2015-05-08  7:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 21:04 perf: WARNING perfevents: irq loop stuck! Vince Weaver
2015-05-01  7:02 ` Ingo Molnar
2015-05-01 17:20   ` Vince Weaver
2015-05-08  4:22   ` Vince Weaver
2015-05-08  7:53     ` Ingo Molnar [this message]
2015-05-08  7:55   ` Ingo Molnar
2015-05-18 17:48     ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150508075347.GB5403@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).