From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbbEHJTz (ORCPT ); Fri, 8 May 2015 05:19:55 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:36504 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbbEHJTw (ORCPT ); Fri, 8 May 2015 05:19:52 -0400 Date: Fri, 8 May 2015 11:19:53 +0200 From: Christoffer Dall To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de, Gleb Natapov , Jonathan Corbet , "open list:DOCUMENTATION" , open list , "open list:ABI/API" Subject: Re: [PATCH v3 01/12] KVM: add comments for kvm_debug_exit_arch struct Message-ID: <20150508091953.GA24744@cbox> References: <1430929407-3487-1-git-send-email-alex.bennee@linaro.org> <1430929407-3487-2-git-send-email-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430929407-3487-2-git-send-email-alex.bennee@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2015 at 05:23:16PM +0100, Alex Bennée wrote: > Bring into line with the comments for the other structures and their > KVM_EXIT_* cases. Also update api.txt to reflect use in kvm_run > documentation. > > Signed-off-by: Alex Bennée > Reviewed-by: David Hildenbrand > Reviewed-by: Andrew Jones > > --- > > v2 > - add comments for other exit types > v3 > - s/commentary/comments/ > - add rb tags > - update api.txt kvm_run to include KVM_EXIT_DEBUG desc > > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt > index 9fa2bf8..cb90025 100644 > --- a/Documentation/virtual/kvm/api.txt > +++ b/Documentation/virtual/kvm/api.txt > @@ -3070,11 +3070,13 @@ data_offset describes where the data is located (KVM_EXIT_IO_OUT) or > where kvm expects application code to place the data for the next > KVM_RUN invocation (KVM_EXIT_IO_IN). Data format is a packed array. > > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > > -Unused. > +If the exit_reason in KVM_EXIT_DEBUG, then a vcpu is processing a debug event s/in/is/ > +for which architecture dependant information is returned. s/dependant/dependent/ (but maybe architecture specific is better) > > /* KVM_EXIT_MMIO */ > struct { > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 4b60056..70ac641 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -237,6 +237,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -285,6 +286,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -295,6 +297,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; > -- > 2.3.5 > otherwise: Acked-by: Christoffer Dall