From: Mark Brown <broonie@kernel.org>
To: Michael Welling <mwelling@ieee.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS
Date: Fri, 8 May 2015 18:09:16 +0100 [thread overview]
Message-ID: <20150508170916.GD2761@sirena.org.uk> (raw)
In-Reply-To: <1431041814-24757-3-git-send-email-mwelling@ieee.org>
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote:
> + if (gpio_is_valid(spi->cs_gpio)) {
> + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0)
> + gpio_direction_output(spi->cs_gpio,
> + !(spi->mode & SPI_CS_HIGH));
> + }
I'm not seeing anything that frees this GPIO?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-08 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 23:36 [PATCH v4 0/2] spi: omap2-mcspi: Add support for GPIO chipselects Michael Welling
2015-05-07 23:36 ` [PATCH v4 1/2] spi: omap2-mcspi: Switch driver to use transfer_one Michael Welling
2015-05-08 16:59 ` Mark Brown
2015-05-07 23:36 ` [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS Michael Welling
2015-05-08 17:09 ` Mark Brown [this message]
2015-05-08 17:37 ` Michael Welling
2015-05-08 17:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508170916.GD2761@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).