From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbbEHRhj (ORCPT ); Fri, 8 May 2015 13:37:39 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:33721 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbEHRhg (ORCPT ); Fri, 8 May 2015 13:37:36 -0400 Date: Fri, 8 May 2015 12:37:37 -0500 From: Michael Welling To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS Message-ID: <20150508173737.GA5991@deathray> References: <1431041814-24757-1-git-send-email-mwelling@ieee.org> <1431041814-24757-3-git-send-email-mwelling@ieee.org> <20150508170916.GD2761@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150508170916.GD2761@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2015 at 06:09:16PM +0100, Mark Brown wrote: > On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote: > > > + if (gpio_is_valid(spi->cs_gpio)) { > > + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0) > > + gpio_direction_output(spi->cs_gpio, > > + !(spi->mode & SPI_CS_HIGH)); > > + } > > I'm not seeing anything that frees this GPIO? Ooops I forgot to add this to the cleanup function. It appears that the transfer_one patch got applied so how should I provide the new version of this patch?