From: Mark Rutland <mark.rutland@arm.com>
To: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Kumar Gala <galak@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components
Date: Mon, 11 May 2015 12:04:22 +0100 [thread overview]
Message-ID: <20150511110422.GA4595@leverpostej> (raw)
In-Reply-To: <B19B6A91-0CF2-428B-8CAC-FFEDD5D3D094@linaro.org>
On Fri, May 08, 2015 at 07:17:12PM +0100, Ivan T. Ivanov wrote:
>
> > On May 8, 2015, at 9:00 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > On Fri, May 08, 2015 at 02:47:57PM +0100, Ivan T. Ivanov wrote:
> >>
> >> On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote:
> >>> On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@linaro.org> wrote:
> >>>> Add initial set of CoreSight components found on Qualcomm's 8x16 chipset.
> >>>>
> >>>>
> >>>> + replicator@824000 {
> >>>> + compatible = "qcom,coresight-replicator", "arm,primecell";
> >>>
> >>> Shouldn't it be "qcom,coresight-replicator1x" ?
> >>>
> >>
> >>
> >>
> >> True, I still wonder, why we have to have this compatible string?
> >> Drivers are probed by amba_id and "arm,primecell", after all.
> >
> > The compatible string tells you both the device _and_ the format of the
> > other properties, because it tells you which binding applies.
> >
> > So the compatible string should be present regardless, as
> > "arm,primecell" does not define the majority of the properties you need
> > for the replicator node.
>
> Mmm, only if vendors don’t bother to update version information
> fused to revision id registers, which happens. And this could
> be workaround by "arm,primecell-periphid”, no?
No. That only tells you the identity of the device, not the format of
the binding.
Thanks,
Mark.
prev parent reply other threads:[~2015-05-11 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 15:36 [PATCH v2 0/2] Add initial CoreSight support for the Qualcomm 8x16 chipsets Ivan T. Ivanov
2015-05-07 15:36 ` [PATCH v2 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver Ivan T. Ivanov
2015-05-11 19:07 ` Mathieu Poirier
2015-05-18 12:51 ` Ivan T. Ivanov
2015-05-07 15:36 ` [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components Ivan T. Ivanov
2015-05-08 13:38 ` Mathieu Poirier
2015-05-08 13:47 ` Ivan T. Ivanov
2015-05-08 14:13 ` Mathieu Poirier
2015-05-08 14:17 ` Ivan T. Ivanov
2015-05-08 16:17 ` Mathieu Poirier
2015-05-08 17:57 ` Ivan T. Ivanov
2015-05-08 18:01 ` Mathieu Poirier
2015-05-08 18:00 ` Mark Rutland
2015-05-08 18:17 ` Ivan T. Ivanov
2015-05-11 11:04 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511110422.GA4595@leverpostej \
--to=mark.rutland@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=Will.Deacon@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.ivanov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=pratikp@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).