From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933697AbbELRyM (ORCPT ); Tue, 12 May 2015 13:54:12 -0400 Received: from imap.thunk.org ([74.207.234.97]:59912 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932809AbbELRyK (ORCPT ); Tue, 12 May 2015 13:54:10 -0400 Date: Tue, 12 May 2015 13:54:06 -0400 From: "Theodore Ts'o" To: Oscar Forner Martinez Cc: linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: Fixed two coding style errors, spaces required around = Message-ID: <20150512175406.GA18150@thunk.org> Mail-Followup-To: Theodore Ts'o , Oscar Forner Martinez , linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org References: <1423053226-10210-1-git-send-email-oscar.forner.martinez@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423053226-10210-1-git-send-email-oscar.forner.martinez@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 04, 2015 at 12:33:46PM +0000, Oscar Forner Martinez wrote: > Two lines with assignation without spaces around the = > > Signed-off-by: Oscar Forner Martinez NACK, we don't generally take code cleanup patches unless it's part of changes in that part of the code. Otherwise, code cleanup patches break other people's pending patches which are waiting code review; and so "code cleanup" patches end up adding negative, not positive, value. Regards, - Ted