From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754536AbbEMMRu (ORCPT ); Wed, 13 May 2015 08:17:50 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37051 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754459AbbEMMRp (ORCPT ); Wed, 13 May 2015 08:17:45 -0400 Date: Wed, 13 May 2015 12:10:51 +0100 From: Mark Brown To: Yingjoe Chen Cc: leilk liu , Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Pawel Moll , Ian Campbell , Hongzhou Yang , Catalin Marinas , Sascha Hauer , Will Deacon , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Sascha Hauer , Kumar Gala , Matthias Brugger , Eddie Huang , linux-arm-kernel@lists.infradead.org Message-ID: <20150513111051.GH3066@sirena.org.uk> References: <1431075343-7887-1-git-send-email-leilk.liu@mediatek.com> <1431075343-7887-3-git-send-email-leilk.liu@mediatek.com> <20150508175306.GG2761@sirena.org.uk> <1431434356.2128.9.camel@mhfsdcap03> <20150512160540.GB3066@sirena.org.uk> <1431509166.25254.12.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LNKrWK8T5LDJo+fl" Content-Disposition: inline In-Reply-To: <1431509166.25254.12.camel@mtksdaap41> X-Cookie: Auction: User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 188.29.164.234 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LNKrWK8T5LDJo+fl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 13, 2015 at 05:26:06PM +0800, Yingjoe Chen wrote: > On Tue, 2015-05-12 at 17:05 +0100, Mark Brown wrote: > > > > There were three compatible strings listed in the DT binding but only > > > > two here. > > > And I test it's ok on MT8135 platform. So I add struct of_device_id > > > mtk_spi_of_match like this in spi driver code. > > You should list all the compatibles documented in the binding here, if > > some of them are the same just have them map to a single constant. > Just for clarification. If we want to add spi support for a new soc, say > mt8127, which we think is compatible to mt6589. Since it may turn out we > need special handling for this soc latter, it is suggested to write > compatible like this in mt8127.dtsi: > compatible = "mediatek,mt8127-spi", > "mediatek,mt6589-spi"; > Device tree binding should list all possible compatible string in .dts, > so we'll have to add that to binding as well. > - mediatek,mt6589-spi: for mt6589 platforms > + - mediatek,mt8127-spi: for mt8127 platforms > Then we'll also need to add this to source code to reflect this. > { .compatible = "mediatek,mt6589-spi", .data = (void *)COMPAT_MT6589}, > + { .compatible = "mediatek,mt8127-spi", .data = (void *)COMPAT_MT6589}, > This seems to introduce lots of trivial patches just to add a compatible > device to me... Yes, but that's how DT works and as you say these patches are all trivial so it's not like they take any appreciable effort. --LNKrWK8T5LDJo+fl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVUzE7AAoJECTWi3JdVIfQMAYH/19Vg5CJGxrJXpIZAxTxWN7x YirZDjnjp7jzn+l0q7/JeyLTiYj9c1GhBidFvZ1XNfXiUtEvkcBNriqbvb04dkh1 5p8av1zOEA7z/WZYKiZ5qW99A21fiapozLljrJZzMUUxXWMKfi868OzG3okpQxq6 sWA4ZnSQ1koJ7i3RHnzIpXfbaIKkF/KzgR4+dlx6PUVKEeuBPgTfcfYSIj4X+ft1 Ul3vIE5e99OJsymxXsL1XRZr9+BZaEGknk3GM+maaoJ1x1Ov2bApShd7WJBcefNH +exK3v5SaLuyUVFvR79cyuB8Qwtklza6pW1uExMdRTmviEbCbDYSI70MDwOGsZs= =TDyi -----END PGP SIGNATURE----- --LNKrWK8T5LDJo+fl--