linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	<linux-kernel@vger.kernel.org>,
	Fengguang Wu <fengguang.wu@intel.com>,
	"Aaron Lu" <aaron.lu@intel.com>, Tony Li <tony.li@amd.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Mwait usage on AMD processors
Date: Thu, 14 May 2015 21:38:57 +0800	[thread overview]
Message-ID: <20150514133857.GB6552@hr-slim.amd.com> (raw)
In-Reply-To: <20150514112303.GC29125@pd.tnic>

On Thu, May 14, 2015 at 01:23:03PM +0200, Borislav Petkov wrote:
> On Thu, May 14, 2015 at 06:17:28PM +0800, Huang Rui wrote:
> > At current processors, MWAITX cannot go to C1 state, but has faster
> > waiting exit speed. MWAITX is still at C0 but less power consumption.
> > So for now, I just want to set it optionally.
> > HW designer will do deeper low power state (C1, and more) in future
> > processors. At that time, we can enable it by default.
> 
> The only thing that matters IMO is which brings more power savings. If
> C1E is still better, we should keep it the default. We can still use
> MWAITX if someone boots with idle=mwait, as you say.
> 

Is C1E here you mentioned is waiting state that use mwaitx enters at
AMD platform? If yes, please see below comments:

Current processor:
Power saving: C0 < C1E (AMD) < C1
Performance: Halt < Mwait <= Mwaitx
Halt -> C1, and Mwaitx/Mwait -> C1E (AMD)

Consider about the balance between power consumption and performance,
so we want to expose the interface. And mwaitx has different opcode
with traditional mwait. Due to C1E (AMD) less power saving that real
C1, so you can think it still in C0 at current.

In furture processor:
HW designer would do Mwaitx -> C1 or deeper low power state.

BTW, could I expose it and send the patches to review?

Thanks,
Rui

  reply	other threads:[~2015-05-14 13:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14  6:54 Mwait usage on AMD processors Huang Rui
2015-05-14  9:21 ` Borislav Petkov
2015-05-14 10:17   ` Huang Rui
2015-05-14 11:23     ` Borislav Petkov
2015-05-14 13:38       ` Huang Rui [this message]
2015-05-14 14:20         ` Borislav Petkov
2015-05-19  7:25           ` Huang Rui
2015-05-19  8:50             ` Borislav Petkov
2015-05-19  9:42               ` Huang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514133857.GB6552@hr-slim.amd.com \
    --to=ray.huang@amd.com \
    --cc=aaron.lu@intel.com \
    --cc=bp@alien8.de \
    --cc=fengguang.wu@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).