From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754434AbbEOGxA (ORCPT ); Fri, 15 May 2015 02:53:00 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:42870 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334AbbEOGw5 (ORCPT ); Fri, 15 May 2015 02:52:57 -0400 Date: Fri, 15 May 2015 14:52:22 +0800 From: Herbert Xu To: LABBE Corentin Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, maxime.ripard@free-electrons.com, linux@arm.linux.org.uk, davem@davemloft.net, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, joe@perches.com, tj@kernel.org, arnd@arndb.de, boris.brezillon@free-electrons.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator Message-ID: <20150515065222.GA16808@gondor.apana.org.au> References: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com> <1431608341-10936-5-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431608341-10936-5-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote: > > +int sun4i_hash_export(struct ahash_request *areq, void *out) > +{ > + struct sun4i_req_ctx *op = ahash_request_ctx(areq); > + > + memcpy(out, op, sizeof(struct sun4i_req_ctx)); > + return 0; > +} > + > +int sun4i_hash_import(struct ahash_request *areq, const void *in) > +{ > + struct sun4i_req_ctx *op = ahash_request_ctx(areq); > + > + memcpy(op, in, sizeof(struct sun4i_req_ctx)); This is very wrong. You're importing an arbitrary ss pointer. The whole point of having an import function instead of just a simple memcpy is to deal with such problems. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt