From: Pavel Machek <pavel@ucw.cz>
To: Jan Roemisch <maxx@spaceboyz.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
pali.rohar@gmail.com,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] radio-bcm2048: Fix region selection
Date: Mon, 18 May 2015 12:52:32 +0200 [thread overview]
Message-ID: <20150518105232.GA15632@amd> (raw)
In-Reply-To: <20150516152049.GB6140@turing.il.maxx.spaceboyz.net>
On Sat 2015-05-16 17:20:50, Jan Roemisch wrote:
> Removed "Japan wide band" region since this is impossible to do just
> like that. Additionally it's now possible to go back to non-Japanese regions
> without having to reload the module.
Acked-by: Pavel Machek <pavel@ucw.cz>
But note that you'll probably need to do one more resend, with
Signed-off-by:
line.
Thanks and best regards,
Pavel
> Greetings
> Jan Roemisch
>
> On Sat, May 16, 2015 at 07:06:17AM -0700, Greg KH wrote:
> > On Sat, May 16, 2015 at 01:22:27PM +0200, Jan Roemisch wrote:
> > > Oh sorry, the real name is Jan Roemisch.
> >
> > Ok, thanks, can someone please fix up the patches and resend them?
> >
> > greg k-h
> >
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 5382506..d2e7f1e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -342,14 +342,6 @@ static struct region_info region_configs[] = {
> .deemphasis = 50,
> .region = 3,
> },
> - /* Japan wide band */
> - {
> - .channel_spacing = 10,
> - .bottom_frequency = 76000,
> - .top_frequency = 108000,
> - .deemphasis = 50,
> - .region = 4,
> - },
> };
>
> /*
> @@ -741,6 +733,18 @@ static int bcm2048_set_region(struct bcm2048_device *bdev, u8 region)
>
> mutex_lock(&bdev->mutex);
> bdev->region_info = region_configs[region];
> +
> + if (region_configs[region].bottom_frequency < 87500)
> + bdev->cache_fm_ctrl |= BCM2048_BAND_SELECT;
> + else
> + bdev->cache_fm_ctrl &= ~BCM2048_BAND_SELECT;
> +
> + err = bcm2048_send_command(bdev, BCM2048_I2C_FM_CTRL,
> + bdev->cache_fm_ctrl);
> + if (err) {
> + mutex_unlock(&bdev->mutex);
> + goto done;
> + }
> mutex_unlock(&bdev->mutex);
>
> if (bdev->frequency < region_configs[region].bottom_frequency ||
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-05-18 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 11:22 [PATCH] radio-bcm2048: Fix region selection Jan Roemisch
2015-05-16 14:06 ` Greg KH
2015-05-16 15:20 ` Jan Roemisch
2015-05-18 10:52 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-15 21:32 Pali Rohár
2015-05-15 22:51 ` Greg Kroah-Hartman
2015-06-05 11:36 ` Hans Verkuil
2015-06-05 12:01 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518105232.GA15632@amd \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxx@spaceboyz.net \
--cc=mchehab@osg.samsung.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).