From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754518AbbERW10 (ORCPT ); Mon, 18 May 2015 18:27:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54242 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754283AbbERW1Y (ORCPT ); Mon, 18 May 2015 18:27:24 -0400 Date: Mon, 18 May 2015 15:27:23 -0700 From: Andrew Morton To: Leon Romanovsky Cc: dhowells@redhat.com, aarcange@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel() Message-Id: <20150518152723.769799cced031e71582bfa74@linux-foundation.org> In-Reply-To: <1431974526-21788-1-git-send-email-leon@leon.nu> References: <1431974526-21788-1-git-send-email-leon@leon.nu> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 May 2015 21:42:06 +0300 Leon Romanovsky wrote: > kenter/kleave/kdebug are wrapper macros to print functions flow and debug > information. This set was written before pr_devel() was introduced, so > it was controlled by "#if 0" construction. > > This patch refactors the current macros to use general pr_devel() > functions which won't be compiled in if "#define DEBUG" is not declared > prior to that macros. I doubt if anyone has used these in a decade and only a tenth of the mm/nommu.c code is actually wired up to use the macros. I'd suggest just removing it all. If someone later has a need, they can add their own pr_devel() calls.